Code Review
How to review a pull request, write one a reviewer will actually open, and stop changes sitting for days.
A pull request is a request for someone else's attention. Most of the time that attention arrives late, or it arrives and gets spent on formatting the linter should have caught.
The useful part of a review is smaller than the diff. Does the change do what it claims? Does it fit a constraint that is not in the code? Is this an approach the team already tried? A person has to answer those. A checklist that lists them, and leaves the rest to tools, is the one teams keep using.
Review with the reason beside the line
Prodigent puts a brief in front of the diff and the team's own knowledge next to the change it affects. A person still approves.
Try Prodigent freeArticles
-
How to Review a Pull Request
A code review checklist for the part a person has to do: intent, one path through the change, and an honest scope when you do not know the code.
-
A Pull Request Template Reviewers Actually Read
A short pull request template, a filled-in example, and the reason long checkbox templates get skipped.